Skip to content

Conversation

dotasek
Copy link
Contributor

@dotasek dotasek commented Jul 11, 2025

This branch increments the HAPI FHIR version to 8.4.0.

This branch is used to track changes to the HAPI FHIR master branch. When HAPI FHIR 8.4.0 is officially released, this branch will target that release and then be ready to merge to hapi-fhir-jpaserver-starter master branch.

@robogary
Copy link

This Pull Request has failed the formatting check

Please run mvn spotless:apply or mvn clean install -DskipTests to fix the formatting issues.

You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling pre-commit install --hook-type pre-push. This will cause formatting to run automatically whenever you push.

@robogary
Copy link

Formatting check succeeded!

@robogary
Copy link

robogary commented Aug 5, 2025

Formatting check succeeded!

@robogary
Copy link

Formatting check succeeded!

@dotasek dotasek marked this pull request as ready for review August 22, 2025 19:22
@dotasek dotasek changed the title HAPI Release Tracking Branch (8.4.0) - DO NOT MERGE HAPI Release Tracking Branch (8.4.0) Aug 22, 2025
@jkiddo jkiddo requested a review from Copilot August 22, 2025 19:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the HAPI FHIR version from 8.2.0 to 8.4.0 and makes related configuration adjustments.

  • Updates HAPI FHIR parent version to 8.4.0
  • Adjusts the starter revision number from 2 to 1
  • Updates Maven repository configuration to use Central Portal Snapshots

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -5,7 +5,7 @@

<properties>
<java.version>17</java.version>
<hapi.fhir.jpa.server.starter.revision>2</hapi.fhir.jpa.server.starter.revision>
<hapi.fhir.jpa.server.starter.revision>1</hapi.fhir.jpa.server.starter.revision>
Copy link
Preview

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The starter revision is being decremented from 2 to 1, which suggests this might be a rollback or reset. This could cause confusion in version tracking. Consider using a sequential increment or documenting the reason for this change.

Suggested change
<hapi.fhir.jpa.server.starter.revision>1</hapi.fhir.jpa.server.starter.revision>
<hapi.fhir.jpa.server.starter.revision>2</hapi.fhir.jpa.server.starter.revision>

Copilot uses AI. Check for mistakes.

@dotasek dotasek merged commit 95c59d1 into master Aug 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants